brian birtles nickname in mozilla irc on limechat

#15 0x7f8886b35124 in mozilla::StyleSetHandle::Ptr::ResolveStyleFor(mozilla::dom::Element*, nsStyleContext*) /home/zoe/mozilla-inbound/obj-asan/dist/include/mozilla/StyleSetHandleInlines.h:85:3 #14 0x7f8886b9f32a in nsStyleSet::ResolveStyleFor(mozilla::dom::Element*, nsStyleContext*) /home/zoe/mozilla-inbound/layout/style/nsStyleSet.cpp:1325:10

#13 0x7f8886b9f8e3 in nsStyleSet::ResolveStyleFor(mozilla::dom::Element*, nsStyleContext*, TreeMatchContext&) /home/zoe/mozilla-inbound/layout/style/nsStyleSet.cpp:1367:10 #12 0x7f8886b9c1d8 in nsStyleSet::GetContext(nsStyleContext*, nsRuleNode*, nsRuleNode*, nsIAtom*, mozilla::CSSPseudoElementType, mozilla::dom::Element*, unsigned int) /home/zoe/mozilla-inbound/layout/style/nsStyleSet.cpp:949:7 #11 0x7f8886a2d15d in nsAnimationManager::UpdateAnimations(nsStyleContext*, mozilla::dom::Element*) /home/zoe/mozilla-inbound/layout/style/nsAnimationManager.cpp:405:5 #10 0x7f8886a2db25 in nsAnimationManager::BuildAnimations(nsStyleContext*, mozilla::dom::Element*, mozilla::AnimationCollection*, nsTArray >&) /home/zoe/mozilla-inbound/layout/style/nsAnimationManager.cpp:1090:33 #9 0x7f8886a2e50c in CSSAnimationBuilder::Build(nsPresContext*, mozilla::StyleAnimation const&, nsCSSKeyframesRule const*) /home/zoe/mozilla-inbound/layout/style/nsAnimationManager.cpp:627 #8 0x7f8886a2e50c in UpdateOldAnimationPropertiesWithNew(mozilla::dom::CSSAnimation&, mozilla::TimingParams&, nsTArray&, bool, nsStyleContext*) /home/zoe/mozilla-inbound/layout/style/nsAnimationManager.cpp:343:5

#7 0x7f8882e5ca7a in mozilla::dom::KeyframeEffectReadOnly::SetKeyframes(nsTArray&, nsStyleContext*) /home/zoe/mozilla-inbound/dom/animation/KeyframeEffect.cpp:489:5 #6 0x7f8882e51868 in mozilla::dom::KeyframeEffectReadOnly::UpdateProperties(nsStyleContext*) /home/zoe/mozilla-inbound/dom/animation/KeyframeEffect.cpp:590 #5 0x7f8882e51868 in nsTArray::operator=(nsTArray&) /home/zoe/mozilla-inbound/obj-asan/dist/include/nsTArray.h:2100:5 #4 0x7f8882e72401 in nsTArray_Impl::operator=(nsTArray_Impl&) /home/zoe/mozilla-inbound/obj-asan/dist/include/nsTArray.h:903 #2 0x7f8880676e29 in nsTArray_base::ShrinkCapacity(unsigned long, unsigned long) /home/zoe/mozilla-inbound/obj-asan/dist/include/nsTArray-inl.h:230 #1 0x7f8880676e29 in nsTArrayFallibleAllocator::Free(void*) /home/zoe/mozilla-inbound/obj-asan/dist/include/nsTArray.h:170:34 So, I suspect that moving the call of CalculateCumulativeChangeHint() causes timing change, as a result this crash appeared.Ī problem here is also nested calls of GetContext(). We've been suffering from various crashes triggered by undisplayed nodes. One thing I noticed is that all of the stack traces have mozilla::ElementRestyler::RestyleUndisplayedNodes. Actually I have no idea what happened at the top of the stack. I see nothing in particular between them. I am really surprised the change causes crashes because the change basically just moved the call of CalculateCumulativeChangeHint() from inside GetAnimationPropertiesFromKeyframes to.

Brian birtles nickname in mozilla irc on limechat